[PATCH] D154261: [LV] Consider if scalar epilogue is required in getMaximizedVFForTarget.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 09:52:42 PDT 2023


fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/pr56319-vector-exit-cond-optimization-epilogue-vectorization.ll:9
 ; group requires to execute at least one scalar iteration, meaning the last
 ; vector iteration of the epilogue vector loop cannot be executed.
 define void @pr56319(ptr noalias %src, ptr noalias %dst) {
----------------
Ayal wrote:
> Comment above deserves updating? It refers to skipping over the main loop vectorized to VF=32 and jumping to the epilog loop vectorized to VF=8 (with original trip count of 32 and requires scalar epilog), whereas now the main loop is vectorized to VF=8 and the epilog loop is not vectorized at all.
Thanks, I moved the test to `limit-vf-by-tripcount.ll` in e561edaaa56c9a8818d546774b141dead7224b50  and update the trip counts in the test so that there's an iteration of the main loop and epilogue loop, so it keeps testing for the original issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154261/new/

https://reviews.llvm.org/D154261



More information about the llvm-commits mailing list