[PATCH] D154233: [ARM] generate correct code for armv6-m XO big stack operations

Mon Jul 3 08:53:08 PDT 2023

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with a couple minor comments

================
Comment at: llvm/lib/Target/ARM/ARMAsmPrinter.cpp:1145
+  case ARM::tADDi8:
+  case ARM::tLSLri:
     // special cases:
----------------
For the instructions where it's relevant, can you add an assertion that the source and destination registers are equal?

================
Comment at: llvm/lib/Target/ARM/ARMAsmPrinter.cpp:1360
+        Offset = MI->getOperand(3).getImm();
+        AFI->EHPrologueOffsetInRegs[DstReg] |= Offset;
+        break;
----------------
`+=`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154233/new/

https://reviews.llvm.org/D154233