[PATCH] D154351: [llvm][TableGen][Jupyter] Record current python when kernel is installed

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 07:55:56 PDT 2023


DavidSpickett created this revision.
Herald added a project: All.
DavidSpickett requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Previously the kernel.json would always point to `python3` even if you
installed using a python from a virtualenv. This meant that tools like VSCode
would try to run the kernel against the system python and fail.

Added a note to the readme about it. I've removed the need to
add to PYTHONPTHON as well, turns out it wasn't needed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154351

Files:
  llvm/utils/TableGen/jupyter/README.md
  llvm/utils/TableGen/jupyter/tablegen_kernel/assets/kernel.json
  llvm/utils/TableGen/jupyter/tablegen_kernel/install.py
  llvm/utils/TableGen/jupyter/tablegen_kernel/kernel.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154351.536775.patch
Type: text/x-patch
Size: 3529 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230703/35575ba4/attachment.bin>


More information about the llvm-commits mailing list