[PATCH] D153262: [llvm-objcopy] --set-section-flags: allow "large" to add SHF_X86_64_LARGE

Thomas Köppe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 07:04:58 PDT 2023


tkoeppe added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/set-section-flags.test:97
     Type:            SHT_RELA
     Info:            .baz
 
----------------
MaskRay wrote:
> Consider adding a section with `SHF_X86_64_FLAG` and calling objcopy --set-section-flags on it but without specifying "large". Test that the flag is cleared.
Done, I'm just using the previous file and calling --set-section-flags again without `large`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153262/new/

https://reviews.llvm.org/D153262



More information about the llvm-commits mailing list