[llvm] 29f4c39 - [lit] Remove dead code not referenced, documented or tested anywhere
Louis Dionne via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 3 06:45:01 PDT 2023
Author: Louis Dionne
Date: 2023-07-03T09:44:05-04:00
New Revision: 29f4c398717184a019791ed52d1d0d69ed5dabb6
URL: https://github.com/llvm/llvm-project/commit/29f4c398717184a019791ed52d1d0d69ed5dabb6
DIFF: https://github.com/llvm/llvm-project/commit/29f4c398717184a019791ed52d1d0d69ed5dabb6.diff
LOG: [lit] Remove dead code not referenced, documented or tested anywhere
If someone encounters issues due to this patch (e.g. they are using
that test format out-of-tree), please reach out on the review and
we'll figure out a way forward.
Differential Revision: https://reviews.llvm.org/D153534
Added:
Modified:
llvm/utils/lit/lit/formats/__init__.py
llvm/utils/lit/lit/formats/base.py
Removed:
################################################################################
diff --git a/llvm/utils/lit/lit/formats/__init__.py b/llvm/utils/lit/lit/formats/__init__.py
index d0a3c026eccd03..6f3dd38eab9990 100644
--- a/llvm/utils/lit/lit/formats/__init__.py
+++ b/llvm/utils/lit/lit/formats/__init__.py
@@ -1,7 +1,6 @@
from lit.formats.base import ( # noqa: F401
TestFormat,
FileBasedTest,
- OneCommandPerFileTest,
ExecutableTest,
)
diff --git a/llvm/utils/lit/lit/formats/base.py b/llvm/utils/lit/lit/formats/base.py
index 8430f6fe9ed58d..3db817b65c61dd 100644
--- a/llvm/utils/lit/lit/formats/base.py
+++ b/llvm/utils/lit/lit/formats/base.py
@@ -44,97 +44,6 @@ def getTestsInDirectory(self, testSuite, path_in_suite, litConfig, localConfig):
yield t
-###
-
-import re
-import tempfile
-
-
-class OneCommandPerFileTest(TestFormat):
- # FIXME: Refactor into generic test for running some command on a directory
- # of inputs.
-
- def __init__(self, command, dir, recursive=False, pattern=".*", useTempInput=False):
- if isinstance(command, str):
- self.command = [command]
- else:
- self.command = list(command)
- if dir is not None:
- dir = str(dir)
- self.dir = dir
- self.recursive = bool(recursive)
- self.pattern = re.compile(pattern)
- self.useTempInput = useTempInput
-
- def getTestsInDirectory(self, testSuite, path_in_suite, litConfig, localConfig):
- dir = self.dir
- if dir is None:
- dir = testSuite.getSourcePath(path_in_suite)
-
- for dirname, subdirs, filenames in os.walk(dir):
- if not self.recursive:
- subdirs[:] = []
-
- subdirs[:] = [
- d for d in subdirs if (d != ".svn" and d not in localConfig.excludes)
- ]
-
- for filename in filenames:
- if (
- filename.startswith(".")
- or not self.pattern.match(filename)
- or filename in localConfig.excludes
- ):
- continue
-
- path = os.path.join(dirname, filename)
- suffix = path[len(dir) :]
- if suffix.startswith(os.sep):
- suffix = suffix[1:]
- test = lit.Test.Test(
- testSuite, path_in_suite + tuple(suffix.split(os.sep)), localConfig
- )
- # FIXME: Hack?
- test.source_path = path
- yield test
-
- def createTempInput(self, tmp, test):
- raise NotImplementedError("This is an abstract method.")
-
- def execute(self, test, litConfig):
- if test.config.unsupported:
- return (lit.Test.UNSUPPORTED, "Test is unsupported")
-
- cmd = list(self.command)
-
- # If using temp input, create a temporary file and hand it to the
- # subclass.
- if self.useTempInput:
- tmp = tempfile.NamedTemporaryFile(suffix=".cpp")
- self.createTempInput(tmp, test)
- tmp.flush()
- cmd.append(tmp.name)
- elif hasattr(test, "source_path"):
- cmd.append(test.source_path)
- else:
- cmd.append(test.getSourcePath())
-
- out, err, exitCode = lit.util.executeCommand(cmd)
-
- diags = out + err
- if not exitCode and not diags.strip():
- return lit.Test.PASS, ""
-
- # Try to include some useful information.
- report = """Command: %s\n""" % " ".join(["'%s'" % a for a in cmd])
- if self.useTempInput:
- report += """Temporary File: %s\n""" % tmp.name
- report += "--\n%s--\n" "" % open(tmp.name).read()
- report += """Output:\n--\n%s--""" % diags
-
- return lit.Test.FAIL, report
-
-
###
# Check exit code of a simple executable with no input
More information about the llvm-commits
mailing list