[PATCH] D151039: [Docs][llvm-exegesis] Add documentation for memory

Ondrej Sykora via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 05:26:50 PDT 2023


ondrasej added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-exegesis.rst:72
+  value is named using the `<value name>` argument so that it can be referenced
+  later within a map annotation. The size is specified in bytes the the value
+  is taken in hexadecimal. If the size of the value is less than the specified
----------------
Typo: ...in bytes, the value is 


================
Comment at: llvm/docs/CommandGuide/llvm-exegesis.rst:79
+  process. The value name refers to a previously defined memory definition and
+  the address is a decimal number that specifies the address the memory
+  definition should start at. Note that a single memory definition can be
----------------
Would it be possible to parse both decimal and hex? E.g. parse "123" as decimal, and "0x123" as hex.

Similar for the size of the memory (on the other side, the value stored in the memory might be easiest when kept only in hex).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151039/new/

https://reviews.llvm.org/D151039



More information about the llvm-commits mailing list