[PATCH] D154232: [AArch64] NFC : Change the way SVE pseudos are appended

Mon Jul 3 05:14:20 PDT 2023

paulwalker-arm added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64SchedNeoverseV2.td:2144-2146
+def : InstRW<[V2Write_4cyc_1V13], (instregex "^[SU]RSHLR?_ZPmZ_[BHSD]",
+                                             "^[SU]RSHL_ZPZZ_[BHSD]",
+                                             "^[SU]RSHR_(ZPmI|ZPZI)_[BHSD]")>;
----------------
This is one example, of many, that makes this patch not NFC because you're changing the scheduling information `RSHR_ZPZI_*`, which is presumably missing before this point.  What I'd like to see is a simple NFC patch where the pseudo instructions have been renamed (as in a literal renaming of the instructions and their uses).  Then following patch or patches that update the scheduling modes to increase their coverage of pseudo instructions.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154232/new/

https://reviews.llvm.org/D154232