[PATCH] D153421: [mlir][Linalg] Implement the tiling interface for softmax
Quentin Colombet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 3 03:43:29 PDT 2023
qcolombet added inline comments.
================
Comment at: mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:20
#include "mlir/Dialect/Complex/IR/Complex.h"
+#include "mlir/Dialect/Linalg/Utils/Utils.h"
#include "mlir/Dialect/Math/IR/Math.h"
----------------
akuegel wrote:
> This introduces a cycle between LinalgUtils and Linalg. Is this intended?
Ah good catch, I forgot to remove that line.
I saw this problem and in the end I moved the utility functions directly in this file, so the include is actually not needed.
Let me fix that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153421/new/
https://reviews.llvm.org/D153421
More information about the llvm-commits
mailing list