[PATCH] D154258: [RISCV] Refactor vfcvt_rm pseudo insertion case statements. NFC

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 03:35:07 PDT 2023


asb added a comment.

Soft LGTM as this should get a LGTM from someone working more on the vector side. But the change seems mechanically correct, and I get the motivation. I'm not the biggest fan in general of `#define` to remove repetitive code but I think it pays off here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154258/new/

https://reviews.llvm.org/D154258



More information about the llvm-commits mailing list