[llvm] 39b5a02 - [ISel] Improve notes for 'ComplexPattern' class

Xiaodong Liu via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 03:14:40 PDT 2023


Author: Xiaodong Liu
Date: 2023-07-03T18:14:09+08:00
New Revision: 39b5a02b14c0bbb028d36ea56e0170d52d0d7f95

URL: https://github.com/llvm/llvm-project/commit/39b5a02b14c0bbb028d36ea56e0170d52d0d7f95
DIFF: https://github.com/llvm/llvm-project/commit/39b5a02b14c0bbb028d36ea56e0170d52d0d7f95.diff

LOG: [ISel] Improve notes for 'ComplexPattern' class

Add notes for 'Ty' parameter and correct the 'addr' example.

Added: 
    

Modified: 
    llvm/include/llvm/Target/TargetSelectionDAG.td

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Target/TargetSelectionDAG.td b/llvm/include/llvm/Target/TargetSelectionDAG.td
index 4f66cc0c8a6bea..c9024c8fa82632 100644
--- a/llvm/include/llvm/Target/TargetSelectionDAG.td
+++ b/llvm/include/llvm/Target/TargetSelectionDAG.td
@@ -1888,10 +1888,11 @@ class Pat<dag pattern, dag result> : Pattern<pattern, [result]>;
 //
 
 // Complex patterns, e.g. X86 addressing mode, requires pattern matching code
-// in C++. NumOperands is the number of operands returned by the select function;
-// SelectFunc is the name of the function used to pattern match the max. pattern;
-// RootNodes are the list of possible root nodes of the sub-dags to match.
-// e.g. X86 addressing mode - def addr : ComplexPattern<4, "SelectAddr", [add]>;
+// in C++. Ty is the type of return value; NumOperands is the number of operands
+// returned by the select function; SelectFunc is the name of the function used
+// to pattern match the max. pattern; RootNodes are the list of possible root nodes
+// of the sub-dags to match.
+// e.g. X86 addressing mode - def addr : ComplexPattern<iPTR, 4, "SelectAddr", [add]>;
 //
 class ComplexPattern<ValueType ty, int numops, string fn,
                      list<SDNode> roots = [], list<SDNodeProperty> props = [],


        


More information about the llvm-commits mailing list