[PATCH] D152535: [DWARF] Add printout for op-index

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 03:11:04 PDT 2023


StephenTozer accepted this revision.
StephenTozer added a comment.
This revision is now accepted and ready to land.

In D152535#4408692 <https://reviews.llvm.org/D152535#4408692>, @dstenb wrote:

> As values in this column will always be 0 for non-VLIW targets, it might perhaps add a bit of clutter. If you prefer, I can instead upload a patch that makes the emission of the column conditional (for line number programs with `maximum_operations_per_instruction > 1`).

This //sounds// preferable to me, but we don't currently make columns conditional based on whether or not they're needed, even when we could (`isa` and `discriminator` are also all-0 for many targets); defensively I'd suggest leaving it as it is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152535/new/

https://reviews.llvm.org/D152535



More information about the llvm-commits mailing list