[PATCH] D152891: [ADT] Add deduction guide for iterator_range

[Balázs Benics via Phabricator via llvm-commits]

steakhal added inline comments.


================
Comment at: llvm/include/llvm/ADT/iterator_range.h:28
+template <typename From, typename To, typename = void>
+struct explicitly_convertable : std::false_type {};
+
----------------
barannikov88 wrote:
> Would go in line with the standard name https://en.cppreference.com/w/cpp/types/is_convertible
> 
I tried to use the llvm's implementation (libcxx) of `std::is_convertible` here but it didn't work.
I managed to replace the `requires` with plain-old SFINAE, and make my implementation pass all the libcxx tests but still failed to compile the llvm-project after this.

About the typo, yea, my bad. I should have fixed that.
How about if we wait for some time to see if at least the bots won't find any semantic issues? After a couple of days, we can fix the typo as well. Otherwise, we would risk merge conflicts in case we need to revert this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152891/new/

https://reviews.llvm.org/D152891