[PATCH] D154084: [AArch64] Modify SVE Pseudo appends

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 01:06:41 PDT 2023


dmgreen added inline comments.


================
Comment at: llvm/unittests/Target/AArch64/AArch64SvePseudoTest.cpp:83
+
+TEST(AArch64SVESchedPseudoTest, IsCorrect) {
+  // TODO : Add more CPUs that support SVE/SVE2
----------------
Can you make this two tests, one for each CPU. It can make the tests easier to work with if they fail, where it is better to have each test more independant.

The neoverse-v2 part may want to be moved to D154232 to keep that patch as an NFC. This patch could then be to improve A510.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154084/new/

https://reviews.llvm.org/D154084



More information about the llvm-commits mailing list