[PATCH] D149439: [yaml2obj] Add support fot structured section data.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 00:34:17 PDT 2023


jhenderson added inline comments.


================
Comment at: llvm/lib/ObjectYAML/COFFYAML.cpp:604
   // is carried in SizeOfRawData, even though PointerToRawData is zero.
-  if (Sec.SectionData.binary_size() == 0 &&
+  if (Sec.SectionData.binary_size() == 0 && Sec.StructuredData.empty() &&
       NC->Characteristics & COFF::IMAGE_SCN_CNT_UNINITIALIZED_DATA)
----------------
Test case that shows this bit of code has changed (correctly)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149439/new/

https://reviews.llvm.org/D149439



More information about the llvm-commits mailing list