[PATCH] D149440: [yaml2obj] Add support for load config section data.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I'd recommend you have test cases where all the fields are present and none of them are. For the purposes of yaml2obj testing, it doesn't actually need to make sense as an output file!



================
Comment at: lld/COFF/Config.h:107
   bool is64() const {
-    return machine == AMD64 || llvm::COFF::isAnyArm64(machine);
+    return llvm::COFF::is64Bit(machine);
   }
----------------
Unrelated? Perhaps should be a follow-up change...


================
Comment at: llvm/lib/ObjectYAML/COFFEmitter.cpp:608
+  if (sizeof(S) < S.Size)
+    OS.write_zeros(S.Size - sizeof(S));
+}
----------------
You should have a test case for the behaviours in this function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149440/new/

https://reviews.llvm.org/D149440