[PATCH] D154193: [X86]Remove TEST in AND32+TEST16rr in peephole-opt

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 2 19:06:56 PDT 2023


pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:985-986
+         "CmpInstr is an analyzable TEST16rr/TEST64rr, and "
+         "`X86InstrInfo::analyzeCompare` "
+         "requires two reg operands are the same.");
 
----------------
XinWang10 wrote:
> pengfei wrote:
> > Can they be merged to one line?
> Then the merged line would exceed 80 chars.
Then you can put the exceeded part in the next line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154193/new/

https://reviews.llvm.org/D154193



More information about the llvm-commits mailing list