[PATCH] D154193: [X86]Remove TEST in AND32+TEST16rr in peephole-opt
Wang, Xin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 2 18:51:47 PDT 2023
XinWang10 added a comment.
================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:985-986
+ "CmpInstr is an analyzable TEST16rr/TEST64rr, and "
+ "`X86InstrInfo::analyzeCompare` "
+ "requires two reg operands are the same.");
----------------
pengfei wrote:
> Can they be merged to one line?
Then the merged line would exceed 80 chars.
================
Comment at: llvm/test/CodeGen/X86/peephole-test-after-add.mir:41
+ define i16 @erase_test16(i16 %0, i16 %1, ptr nocapture %2) {
+ entry:
----------------
pengfei wrote:
> Maybe pre-commit the test?
Will do, to make the change clear.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154193/new/
https://reviews.llvm.org/D154193
More information about the llvm-commits
mailing list