[PATCH] D147990: [BPF] Undo transformation for LICM.cpp:hoistMinMax()

Sun Jul 2 17:00:21 PDT 2023

yonghong-song added a comment.

In D147990#4465164 <https://reviews.llvm.org/D147990#4465164>, @eddyz87 wrote:

> Hi Yonghong,
>
> Could you please take a look?
> I checked this revision against kernel master and see code generation change in a single test: get_branch_snapshot.c, the test contains pattern in question. No veristat changes for Cilium programs [2].
> I also verified that selftests at revision [1] (the last revision before your fixes for `check_cond_jmp_op()`) are passing when using this revision (and loop6 fails if `main` is used instead of this revision).
> Unfortunately, after thinking on loop6 behavior a bit more I can't suggest a better solution than this.
>
> [1] 360cd42c4e95 ("io_uring: optimise io_req_local_work_add")

I think this link [1] is not correct. You probably mean something else.

But, the patch looks good to me. Thanks!

> [2] https://github.com/anakryiko/cilium

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147990/new/

https://reviews.llvm.org/D147990