[PATCH] D152373: [TableGen] Support warnings on unused classes and multiclasses.

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 added a comment.

In D152373#4423873 <https://reviews.llvm.org/D152373#4423873>, @foad wrote:

> The implementation looks good to me, except perhaps for `isInCommonTableGenHeader`. It seems like you're inventing a new concept of C-like "system headers", which TableGen did not previously have.

I like it, but maybe instead add the equivalent option (-isystem) and pass it from CMake? Paths may change, and there are also at least clang and mlir that might want to enable this warning.

In D152373#4458773 <https://reviews.llvm.org/D152373#4458773>, @nhaehnle wrote:

> As shown by the many related revisions, this is clearly a good idea.
>
> I'm wracking my brain as for how the "common" TableGen files can be identified in a cleaner way. I don't like the `def` way, but something like a `pragma common_header` perhaps?

"common header" sounds rather vague. Maybe add a way to disable/enable specific warning?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152373/new/

https://reviews.llvm.org/D152373