[PATCH] D152373: [TableGen] Support warnings on unused classes and multiclasses.

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 02:40:48 PDT 2023


kosarev added a comment.

> Maybe you could specify on the command line which files you //do// want to see warnings in?
> `llvm-tblgen -warn-in=lib/Target/AMDGPU/ ...`

Would be easy to implement, but feels a bit like we ask the user to provide information that should already be known to the system. To be compared with something like `gcc --warn-in=foo.c foo.c`.

> I'm wracking my brain as for how the "common" TableGen files can be identified in a cleaner way. I don't like the `def` way, but something like a `pragma common_header` perhaps?

Yeah, a pragma was my first thought as well, so probably should be most natural and expected, though it's yet another concept to be added. Will try that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152373/new/

https://reviews.llvm.org/D152373



More information about the llvm-commits mailing list