[PATCH] D154233: [ARM] generate correct code for armv6-m XO big stack operations

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMAsmPrinter.cpp:1361
+      case ARM::tLSLri:
+        break;
       case ARM::t2PAC:
----------------
I'd prefer to actually verify the tLSLri has the expected shift amount/source/destination.


================
Comment at: llvm/test/CodeGen/ARM/large-stack.ll:24
+; CHECK-NEXT: lsls    [[REG]], [[REG]], #0x8
+; CHECK-NEXT: adds    [[REG]], #0xb8
     %tmp = alloca [ 4168 x i8 ] , align 4
----------------
The generated code here is ridiculously inefficient; do you have some plan for generating code that's closer to optimal?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154233/new/

https://reviews.llvm.org/D154233