[PATCH] D154168: [X86] Split SDISel call lowering out to its own file
Phoebe Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 30 07:51:42 PDT 2023
pengfei added a comment.
Not aware any precedent, but I think it's always good for both reducing compile time and code clear.
================
Comment at: llvm/lib/Target/X86/CMakeLists.txt:56
X86InstructionSelector.cpp
+ X86ISelCallLowering.cpp
X86ISelDAGToDAG.cpp
----------------
Would it be better to use `X86ISelLoweringCall`? I think it's more clean to start with `X86ISelLowering` if we have more such split in the future, and it's easy to understand they are extracted from `X86ISelLowering`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154168/new/
https://reviews.llvm.org/D154168
More information about the llvm-commits
mailing list