[PATCH] D154168: [X86] Split SDISel call lowering out to its own file
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 29 16:10:24 PDT 2023
rnk created this revision.
rnk added reviewers: RKSimon, pengfei.
Herald added subscribers: abrachet, phosek, hiraditya.
Herald added a project: All.
rnk requested review of this revision.
Herald added a project: LLVM.
X86ISelLoewring is unbearably slow to compile. Split "the important
stuff", which to me at least is call lowering, into it's own file.
Now I can test calling convention changes with <5s rebuilds. The rest of
X86ISelLowering is still a disaster zone of slow compilation, but this
seems like a good incremental step forward, similar to the way
globalisel call lowering is structured. They even stole the proper file
name, X86CallLowering.cpp.
clang-format complains, but I didn't want to reformat because it will make it
harder for git rename detection and blame tools.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D154168
Files:
llvm/lib/Target/X86/CMakeLists.txt
llvm/lib/Target/X86/X86ISelCallLowering.cpp
llvm/lib/Target/X86/X86ISelLowering.cpp
llvm/lib/Target/X86/X86ISelLowering.h
llvm/utils/gn/secondary/llvm/lib/Target/X86/BUILD.gn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154168.536048.patch
Type: text/x-patch
Size: 259507 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230629/f6caef7e/attachment-0001.bin>
More information about the llvm-commits
mailing list