[PATCH] D154142: [llvm-mca][RISCV] Add RISCV-SEW instrument

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

I've only left a minor comment. Otherwise, patch looks good to me.



================
Comment at: llvm/lib/Target/RISCV/MCA/RISCVCustomBehaviour.cpp:135
+      LI = static_cast<RISCVLMULInstrument *>(I);
+    if (I->getDesc() == RISCVSEWInstrument::DESC_NAME)
+      SI = static_cast<RISCVSEWInstrument *>(I);
----------------
I don't expect different instruments to have the same DESC_NAME. This should probably be an "else if".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154142/new/

https://reviews.llvm.org/D154142