[PATCH] D154056: [BOLT][Instrumentation][NFC] define and use mmap constants

[Denis Revunov via Phabricator via llvm-commits]

treapster added inline comments.


================
Comment at: bolt/runtime/instr.cpp:1554
+             MAP_ANONYMOUS | MAP_SHARED | MAP_FIXED, -1, 0);
+  assert(Ret != MAP_FAILED, "Failed to mmap counters!");
   __bolt_ind_call_counter_func_pointer = __bolt_instr_indirect_call;
----------------
rafauler wrote:
> treapster wrote:
> > Should i remove it from this diff or add it to all mmap calls?
> Why do you ask? I think it's fine
Because i'm not sure it can be called NFC with the check added, but if it is, then we may as well add it to other places


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154056/new/

https://reviews.llvm.org/D154056