[PATCH] D154056: [BOLT][Instrumentation][NFC] define and use mmap constants

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 13:47:23 PDT 2023


rafauler added inline comments.


================
Comment at: bolt/runtime/instr.cpp:1554
+             MAP_ANONYMOUS | MAP_SHARED | MAP_FIXED, -1, 0);
+  assert(Ret != MAP_FAILED, "Failed to mmap counters!");
   __bolt_ind_call_counter_func_pointer = __bolt_instr_indirect_call;
----------------
treapster wrote:
> Should i remove it from this diff or add it to all mmap calls?
Why do you ask? I think it's fine


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154056/new/

https://reviews.llvm.org/D154056



More information about the llvm-commits mailing list