[PATCH] D153829: [AArch64] Move branch relaxation after bbsection assignment

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetPassConfig.h:443
+  /// instructions are finalized. All passes a target implements in this
+  /// function can assume that no pass after it will modify or move any
+  /// instructions. Note that the first pass in this function *can* modify and
----------------
This is quite the claim, given that the wonderfully named "addPreEmitPass2" already exist


================
Comment at: llvm/include/llvm/CodeGen/TargetPassConfig.h:444
+  /// function can assume that no pass after it will modify or move any
+  /// instructions. Note that the first pass in this function *can* modify and
+  /// insert instructions as necessary, but no subsequent passes can do so.
----------------
I don't understand this, how can such a restriction exist on the use of this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153829/new/

https://reviews.llvm.org/D153829