[PATCH] D153829: [AArch64] Move branch relaxation after bbsection assignment

Daniel Hoekwater via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 14:01:53 PDT 2023


dhoekwater created this revision.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
dhoekwater updated this revision to Diff 535467.
dhoekwater added a comment.
dhoekwater updated this revision to Diff 535512.
dhoekwater updated this revision to Diff 535516.
dhoekwater published this revision for review.
dhoekwater added reviewers: efriedma, arsenm, ostannard, nickdesaulniers, aprantl.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Rename the pass name and give it descriptive documentation.


dhoekwater added a comment.

Update a couple tests to account for RenumberBlocks not having run yet.


dhoekwater added a comment.

Remove FIXMEs. We probably will want to rename preEmitPass functions to something
more reflective of the functions' purposes.


Because branch relaxation needs to factor in if branches target
a block in the same section or a different one, it needs to run
after the Basic Block Sections / Machine Function Splitting passes.

Because Jump table compression relies on block offsets remaining
fixed after the table is compressed, we must also move the JT
compression pass.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153829

Files:
  llvm/include/llvm/CodeGen/TargetPassConfig.h
  llvm/lib/CodeGen/TargetPassConfig.cpp
  llvm/lib/Target/AArch64/AArch64TargetMachine.cpp
  llvm/test/CodeGen/AArch64/O0-pipeline.ll
  llvm/test/CodeGen/AArch64/O3-pipeline.ll
  llvm/test/CodeGen/AArch64/arm64-opt-remarks-lazy-bfi.ll
  llvm/test/CodeGen/AArch64/jti-correct-datatype.mir
  llvm/test/CodeGen/AArch64/seh_funclet_x1.ll
  llvm/test/CodeGen/AArch64/wineh-try-catch.ll
  llvm/test/DebugInfo/AArch64/fallthrough-branch.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153829.535516.patch
Type: text/x-patch
Size: 10998 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230628/861b8c4a/attachment.bin>


More information about the llvm-commits mailing list