[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

Haojian Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 09:58:45 PDT 2023


hokein added a comment.

In D153652#4459489 <https://reviews.llvm.org/D153652#4459489>, @jhenderson wrote:

> The new test LGTM, albeit with one query: I assume `umask` sets some global state. When the lit unit tests are running, do the tests within the same process run sequentially, or are they in parallel at all? If the latter, there could be some thread-safety issue, although I suspect the tests are run sequentially.

Good question. For each lit test, `llvm-lit` will run it on a separate worker process <https://github.com/llvm/llvm-project/blob/main/llvm/utils/lit/lit/run.py#L74>, so we should be safe here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153652/new/

https://reviews.llvm.org/D153652



More information about the llvm-commits mailing list