[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 05:50:30 PDT 2023


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

The new test LGTM, albeit with one query: I assume `umask` sets some global state. When the lit unit tests are running, do the tests within the same process run sequentially, or are they in parallel at all? If the latter, there could be some thread-safety issue, although I suspect the tests are run sequentially.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153652/new/

https://reviews.llvm.org/D153652



More information about the llvm-commits mailing list