[PATCH] D152095: [Verifier] definition subprograms cannot be nested within DICompositeType when enabling ODR.

Thu Jun 29 06:56:05 PDT 2023

DianQK added a comment.

In D152095#4457017 <https://reviews.llvm.org/D152095#4457017>, @dblaikie wrote:

> Not sure I follow - I guess regardless they probably shouldn't be in this change.

I want to remove these two IRs from this change. Since these violate the current convention, these don't make sense anymore.

> I'd expect this change to add the verifier check, and add an example IR that doesn't pass verification/demonstrates the new verifier check correctly catches the intended case(s).

This should be `llvm/test/Verifier/disubprogram-declaration-within-struct.ll`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152095/new/

https://reviews.llvm.org/D152095