[PATCH] D152095: [Verifier] definition subprograms cannot be nested within DICompositeType when enabling ODR.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 28 12:19:25 PDT 2023
dblaikie added a comment.
In D152095#4452275 <https://reviews.llvm.org/D152095#4452275>, @DianQK wrote:
> The modifications made this time still involve manually adding declaration references. I just wanted to demonstrate that these test cases work after removing the previous code and adding the declaration. I can remove these two test cases in the next commit or remove them in this current commit.
Not sure I follow - I guess regardless they probably shouldn't be in this change.
I'd expect this change to add the verifier check, and add an example IR that doesn't pass verification/demonstrates the new verifier check correctly catches the intended case(s).
@aprantl @JDevlieghere Sounds like this verifier check might fail for Swift debug info IR? You folks have any thoughts on that/how to address it/if anything needs to be done before we enable this check? (and how Swift is working with LTO if it generates IR like this... ?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152095/new/
https://reviews.llvm.org/D152095
More information about the llvm-commits
mailing list