[PATCH] D150674: [RISCV] Set GenCrashDialog=false for various report_fatal_error calls in lib/Target/RISCV

Wed Jun 28 16:03:23 PDT 2023

arsenm added a comment.

In D150674#4456128 <https://reviews.llvm.org/D150674#4456128>, @asb wrote:

> In D150674#4349305 <https://reviews.llvm.org/D150674#4349305>, @asb wrote:
>
>> In D150674#4346919 <https://reviews.llvm.org/D150674#4346919>, @arsenm wrote:
>>
>>> This should be the universal default. report_fatal_error should not emit crash dialogs
>>
>> Thanks for taking a look. Just for the sake of clarity, is this a general comment or a request to invert the default behaviour of report_fatal_error rather than landing this patch? If the latter - I'd say I'm happy to help improve things here and even post an RFC on the issue, but I'm also well aware it's likely to take a long time to land (not least as it will re-raise the issue, as this patch has, of inadequacies in LLVM's error handling infrastructure). So my preference would be to land this incremental improvement and separate that from work to flip the default or make other broader changes.
>
> This needs rebasing, but before doing that I wanted to ping again (@arsenm) on this question. It does make sense to me to improve the usage of report_fatal_error within lib/Target/RISCV according to its current interface, separate to any discussion about changing that interface. But let me know if you feel differently.

Yes. I really think the default needs to change, this has been majorly annoying for over 3 years now. Incrementally improving is fine

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150674/new/

https://reviews.llvm.org/D150674