[PATCH] D150674: [RISCV] Set GenCrashDialog=false for various report_fatal_error calls in lib/Target/RISCV

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 14:47:36 PDT 2023


MaskRay added a comment.

I agree that in `lib/Target` and `lib/CodeGen`, there are many `report_fatal_error` places that are difficult to switch to a better error reporting mechanism.
If lib/Target/RISCV does this, should other targets do similar things?

Perhaps you can start a thread on https://discourse.llvm.org/ whether `GenCrashDiag` should default to false, as I think it is worth bringing more attention. FWIW I support defaulting to false.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150674/new/

https://reviews.llvm.org/D150674



More information about the llvm-commits mailing list