[PATCH] D153995: [NFC][Sample PGO] Avoid non-const accessor for CallsiteSamples

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:806
+  void removeAllCallsiteSamples() {
+    CallsiteSamples.clear();
+  }
----------------
marksantaniello wrote:
> Consider "the swap trick" to guarantee that we free the memory?
> 
> ```
>   CallsiteSamplesMap EmptyCallsiteSamples;
>   std::swap(CallsiteSamples, EmptyCallsiteSamples);
> ```
> 
It's a std::map, so clear should be sufficient. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153995/new/

https://reviews.llvm.org/D153995