[PATCH] D153995: [NFC][Sample PGO] Avoid non-const accessor for CallsiteSamples

Mark Santaniello via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 13:00:24 PDT 2023


marksantaniello added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:806
+  void removeAllCallsiteSamples() {
+    CallsiteSamples.clear();
+  }
----------------
Consider "the swap trick" to guarantee that we free the memory?

```
  CallsiteSamplesMap EmptyCallsiteSamples;
  std::swap(CallsiteSamples, EmptyCallsiteSamples);
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153995/new/

https://reviews.llvm.org/D153995



More information about the llvm-commits mailing list