[PATCH] D153927: Resubmit: [NFC] Refactor MBB hotness/coldness into templated PSI functions

[Han Shen via Phabricator via llvm-commits]

shenhan marked an inline comment as done.
shenhan added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ProfileSummaryInfo.h:19
+#include "llvm/Analysis/BlockFrequencyInfo.h"
+#include "llvm/CodeGen/MachineFunction.h"
+#include "llvm/IR/Function.h"
----------------
hokein wrote:
> This seems to introduce a layering violation. 
> 
> After this patch, the llvm::Analysis target now depends on the llvm::CodeGen target, but llvm::CodeGen already depends on llvm::Analysis.
> 
> One fix is to move the moving the full specialization for the MachineFunction to the CodeGen target (MachineSizeOpts.cpp)
Removed the inclusion. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153927/new/

https://reviews.llvm.org/D153927