[PATCH] D153927: Resubmit: [NFC] Refactor MBB hotness/coldness into templated PSI functions
Han Shen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 28 12:09:55 PDT 2023
shenhan reopened this revision.
shenhan edited reviewers, added: MaskRay; removed: aidengrossman.
shenhan added a comment.
This revision is now accepted and ready to land.
The last revision Diff 8 caused bazel build failures, because ProfileSummaryInfo.h includes MachineFunction.h, which creates a cyclic dependency in bazel BUILD rules.
Fixed the issue by moving the template specialization implementation into MachineFunction.cpp, leave only the declaration in ProfileSummaryInfo.h file.
Reran the following builds:
gcc linux
clang linux
cl windows
bazel-5.0.0 build --config=generic_clang/gcc @llvm-project//clang/...
bazel-5.0.0 build --config=generic_clang/gcc @llvm-project//clang-tools-extra/...
bazel-5.0.0 build --config=generic_clang/gcc @llvm-project//mlir/...
bazel-5.0.0 build --config=generic_clang/gcc @llvm-project//lld/...
bazel-5.0.0 build --config=generic_clang/gcc @llvm-project//llvm:CodeGen
Added @MaskRay as reviewers.
================
Comment at: llvm/include/llvm/Analysis/ProfileSummaryInfo.h:343
+ if (auto CallCount = getProfileCount(cast<CallBase>(I), nullptr)) {
+ TotalCallCount += *CallCount;
+ }
----------------
MaskRay wrote:
> The LLVM convention is to omit all braces as the body has just one line.
Removed all cascading braces.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153927/new/
https://reviews.llvm.org/D153927
More information about the llvm-commits
mailing list