[PATCH] D151022: [llvm-exegesis] Introduce SubprocessMemory Utility Class

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

In D151022#4456689 <https://reviews.llvm.org/D151022#4456689>, @aidengrossman wrote:

> I was not considering multi-user setups. I'll look into writing a patch up for that. The process should clean up after its own shared memory. `shm_unlink` should get called in `~SubprocessMemory`, but there's nothing checking that the call actually succeeds. I'll look at doing some more investigation there and probably add an assertion/check within the test.

I was only having a very quick look right now, but afaict there is nothing in that d'tor that handles the auxmem stuff. Those are not added to SharedMemoryNames, so I guess those aren't unlinked.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151022/new/

https://reviews.llvm.org/D151022