[PATCH] D151022: [llvm-exegesis] Introduce SubprocessMemory Utility Class

Aiden Grossman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 09:56:38 PDT 2023


aidengrossman added a comment.

I was not considering multi-user setups. I'll look into writing a patch up for that. The process should clean up after its own shared memory. `shm_unlink` should get called in `~SubprocessMemory`, but there's nothing checking that the call actually succeeds. I'll look at doing some more investigation there and probably add an assertion/check within the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151022/new/

https://reviews.llvm.org/D151022



More information about the llvm-commits mailing list