[PATCH] D153927: Resubmit: [NFC] Refactor MBB hotness/coldness into templated PSI functions
Wenlei He via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 28 09:44:49 PDT 2023
wenlei added a comment.
In D153927#4454956 <https://reviews.llvm.org/D153927#4454956>, @MaskRay wrote:
> Apologies but I am going to revert this patch. There is a layering violation (https://llvm.org/docs/CodingStandards.html#library-layering). LLVMAnalysis cannot depend on LLVMCodeGen. This is breaking our Bazel build.
>
> llvm/include/llvm/Analysis/ProfileSummaryInfo.h:19:10: fatal error: 'llvm/CodeGen/MachineFunction.h' file not found
> 19 | #include "llvm/CodeGen/MachineFunction.h"
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Good catch..
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153927/new/
https://reviews.llvm.org/D153927
More information about the llvm-commits
mailing list