[PATCH] D153927: Resubmit: [NFC] Refactor MBB hotness/coldness into templated PSI functions

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ProfileSummaryInfo.h:134
+
+    if (auto TotalCallCount = getTotalCallCount(F)) {
+      if (isHotCount(*TotalCallCount))
----------------
omit braces


================
Comment at: llvm/include/llvm/Analysis/ProfileSummaryInfo.h:155
+
+    if (auto TotalCallCount = getTotalCallCount(F)) {
+      if (!isColdCount(*TotalCallCount))
----------------
omit braces


================
Comment at: llvm/include/llvm/Analysis/ProfileSummaryInfo.h:343
+        if (auto CallCount = getProfileCount(cast<CallBase>(I), nullptr)) {
+          TotalCallCount += *CallCount;
+        }
----------------
The LLVM convention is to omit all braces as the body has just one line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153927/new/

https://reviews.llvm.org/D153927