[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 05:58:32 PDT 2023

aaron.ballman resigned from this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D150803#4454188 <https://reviews.llvm.org/D150803#4454188>, @sbc100 wrote:

> In D150803#4454164 <https://reviews.llvm.org/D150803#4454164>, @brendandahl wrote:
>> In D150803#4440802 <https://reviews.llvm.org/D150803#4440802>, @aaron.ballman wrote:
>>> Marking as requested changes so it's clear there's more worth discussing, so we don't accidentally land this.
>> I've switched to using `annotate` now. Let me know if there's anything else.
> I guess the CL title and description now need updating?   Nice to see we no longer need any clang changes here!

FWIW, I like this approach! I'm going to resign as a reviewer so that my "requested changes" marking no longer matters, but I'll still be subscribed to the review if folks need me to weigh in on anything for some reason.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list