[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

[Brendan Dahl via Phabricator via llvm-commits]

brendandahl marked an inline comment as not done.
brendandahl added inline comments.


================
Comment at: llvm/test/MC/WebAssembly/func-attr.s:21
+# CHECK-OBJ-NEXT:          Offset:          0x0
+# CHECK-OBJ-NEXT:     Name:            func_attr.custom0
----------------
sbc100 wrote:
> Should these be `llvm.func_attr.custom0` perhaps?
> 
> I also wonder if its makes sense to preserve all of these.  I worry that it could result in production code that contains these extra sections.   Can we figure out way to drop them by default on only preserve them in the cases we care about?
> 
> How about maybe a linker flag?  Something like `--preserve-attributes=async`.. that emcc could inject?
I'm planning to have binaryen remove all of these by default, since they're only needed as hints for binaryen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150803/new/

https://reviews.llvm.org/D150803