[PATCH] D153879: [AMDGPU] Handle Additional Cases in tryFoldPhiAGPR
Pierre van Houtryve via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 28 00:03:07 PDT 2023
Pierre-vh marked 4 inline comments as done.
Pierre-vh added inline comments.
================
Comment at: llvm/test/CodeGen/AMDGPU/fold-agpr-phis.mir:505
+ bb.2:
+ S_ENDPGM 0
+...
----------------
arsenm wrote:
> Could also use and end to end IR test
I don't have one; I can try reducing the original app's code but that may take a while, the kernel is big.
I tried reproducing the pattern I thought was relevant using some functions from mfma_loop but I can't get it to create that two copy pattern. I will try digging a bit more, but is a end-to-end test necessary here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153879/new/
https://reviews.llvm.org/D153879
More information about the llvm-commits
mailing list