[PATCH] D153859: RegisterCoalescer: Fix verifier error on redef of subregister for live out implicit_defs

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 05:02:49 PDT 2023


arsenm created this revision.
arsenm added reviewers: qcolombet, MatzeB, kparzysz, foad.
Herald added subscribers: StephenFan, kerbowa, tpr, hiraditya, jvesely.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

A live out implicit_def wasn't deleted, but the subranges weren't
correctly updated. The main range was correct but the def
corresponding to the initial main range def instruction was missing
from the lanes redefined in another block.

      

The written lanes are not quite the same as the valid lanes in the
case of an implicit_def.

      

Fixes verifier error in blender. There is an additional verifier in
some of the testcase variants where an empty subrange remains.


https://reviews.llvm.org/D153859

Files:
  llvm/lib/CodeGen/RegisterCoalescer.cpp
  llvm/test/CodeGen/AMDGPU/blender-coalescer-verifier-error-empty-subrange.mir
  llvm/test/CodeGen/AMDGPU/blender-no-live-segment-at-def-implicit-def.ll
  llvm/test/CodeGen/AMDGPU/liveout-implicit-def-subreg-redef-blender-verifier-error.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153859.534916.patch
Type: text/x-patch
Size: 12917 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230627/19d7d144/attachment.bin>


More information about the llvm-commits mailing list