[PATCH] D153459: [DebugInfo] Add error handling to DWARFDebugAbbrev::getAbbreviationDeclarationSet

[Alex Langford via Phabricator via llvm-commits]

bulbazord added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugAbbrev.cpp:162
+  if (Error Err = AbbrDecls.extract(*Data, &Offset))
+    return std::move(Err);
 
----------------
dblaikie wrote:
> no need for std::move here, I think? (implicit move from a local variable when you `return local`)
Last time I did that, some older compilers on some buildbots didn't like it. I added the `std::move` to be explicit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153459/new/

https://reviews.llvm.org/D153459