[PATCH] D153459: [DebugInfo] Add error handling to DWARFDebugAbbrev::getAbbreviationDeclarationSet

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 11:49:43 PDT 2023


dblaikie added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugAbbrev.cpp:162
+  if (Error Err = AbbrDecls.extract(*Data, &Offset))
+    return std::move(Err);
 
----------------
no need for std::move here, I think? (implicit move from a local variable when you `return local`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153459/new/

https://reviews.llvm.org/D153459



More information about the llvm-commits mailing list