[PATCH] D151449: [RISCV] Add DAG combine for CTTZ/CTLZ in the case of input 0

Mikhail Gudim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 06:47:12 PDT 2023


mgudim added a comment.

@djtodoro Thanks for working on this. LGTM, given that you fix the tests. I would feel more comfortable if someone else (@asb, @craig.topper, @reames) gave a final approval.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:11429
+  SDValue CTZ;
+
+  SDValue ValOnZero;
----------------
Suggestion: I would use `Count` or `CountZeroes`. On ARM `CTZ` means `CTTZ`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151449/new/

https://reviews.llvm.org/D151449



More information about the llvm-commits mailing list