[PATCH] D151020: [llvm-exegesis] Add ability to assign perf counters to specific PID

Aiden Grossman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 25 16:42:16 PDT 2023


aidengrossman added a comment.

It looks like the approach that lldb takes in regards to `pid_t` is to include `sys/types.h` (which is where the type is defined according to POSIX) everywhere except where `_MSC_VER` is defined (so MSVC and Clang on Windows) and then typedeffing it as `uint32_t` (why that specific type I'm not sure since POSIX mandates it is a signed integer type, but 32 bits is fine). I'm going to take this approach and reland this commit after some testing. Hopefully there aren't any further regressions from this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151020/new/

https://reviews.llvm.org/D151020



More information about the llvm-commits mailing list